Re: [PATCH v6 2/3] RAS/AMD/ATL: Translate UMC normalized address to DRAM address using PRM

On Mon, Jun 29, 2026 at 10:33:39PM -0700, Borislav Petkov wrote:
> On Mon, Jun 29, 2026 at 11:07:30AM -0400, Yazen Ghannam wrote:
> > @@ -210,7 +210,8 @@ static int __init amd_atl_init(void)
> >  
> >  	/* Increment this module's recount so that it can't be easily unloaded. */
> >  	__module_get(THIS_MODULE);
> > -	amd_atl_register_decoder(convert_umc_mca_addr_to_sys_addr);
> > +	amd_atl_register_decoder(convert_umc_mca_addr_to_sys_addr,
> > +				 convert_umc_mca_addr_to_dram_addr);
> 
> This thing with passing in a function pointer from mce_amd was a hack back
> then. Now we're doing this here and we're passing in another pointer too.
> Yeah, let's rip it out and have users of the decoding library call the library
> directly.
> 
> Oh, and let's shorten those function names somewhat:
> amd_convert_umc_mca_addr_to_dram_addr is an unreadable mouthful.
> 
> Diff ontop:

Overall, looks good.

There are some minor formatting and build issues. I can send a v7 with
those fixed.

Thanks,
Yazen