Re: [PATCH] edac: edac_device_sysfs: replace simple_strtoul with kstrtoul
Borislav Petkov <[email protected]> Tue, 7 Jul 2026 14:48:15 -0700
| Newsgroups | org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260707214815.GEak10Hzqvwce_kpYv@fat_crate.local> |
On Tue, Jun 23, 2026 at 12:53:23PM +0100, Jad Keskes wrote: > simple_strtoul is deprecated. These calls also didn't validate input - > echoing 'garbage' would just set the value to 0 with no error. > > Use kstrtoul instead so bogus data gets -EINVAL back. > > Signed-off-by: Jad Keskes <[email protected]> > --- > drivers/edac/edac_device_sysfs.c | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) Sashiko is reporting two pre-existing issues here: https://sashiko.dev/#/patchset/20260623115323.519298-1-inasj268%40gmail.com Would you like to take care of them too, in separate patches? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette