Re: [PATCH] EDAC: fsl_ddr: use devm_platform_ioremap_resource()

Borislav Petkov <[email protected]> Sun, 19 Jul 2026 08:58:22 -0700
Newsgroups org.kernel.vger.linux-edac,dev.linux.lists.imx,dev.linux.lists.llvm,org.kernel.vger.linux-kernel
Message-ID <20260719155822.GAalz0Hj3XT97KkPOk@fat_crate.local>
On Wed, Jul 15, 2026 at 11:00:50PM -0500, Frank Li wrote:
> On Tue, Jul 14, 2026 at 04:46:09PM -0700, Rosen Penev wrote:
> > Replace the open-coded of_address_to_resource() plus devm_request_mem_region()
> > and devm_ioremap() sequence with devm_platform_ioremap_resource(), which folds
> > the resource lookup, region reservation and mapping into one step and returns
> > an ERR_PTR checked with IS_ERR()/PTR_ERR().
> >
> > Behaviorally equivalent with respect to region reservation: the driver
> > already reserved the region, so the non-overlapping reg requirement was
> > already satisfied. Drop the now-unused linux/of_address.h include.
> >
> > Built for arm64 (defconfig + CONFIG_EDAC_FSL_DDR) with LLVM=1;
> > drivers/edac/fsl_ddr_edac.o compiles cleanly.
> >
> > Assisted-by: opencode:hy3-free
> > Signed-off-by: Rosen Penev <[email protected]>
> > ---
> 
> Reviewed-by: Frank Li <[email protected]>

Sashiko caught a bunch of preexisting issues:

https://sashiko.dev/#/patchset/20260714234609.902367-1-rosenp%40gmail.com

Let's fix them first please.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette