[PATCHv2 2/3] EDAC/fsl_ddr: use non devm for request_irq()
Rosen Penev <[email protected]> Thu, 30 Jul 2026 18:21:29 -0700
| Newsgroups | org.kernel.vger.linux-edac,dev.linux.lists.imx,dev.linux.lists.llvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
We need to tear down the irq before edac_mc_free() to avoid a use after free on teardown as request_irq uses mci as dev_id. Signed-off-by: Rosen Penev <[email protected]> --- drivers/edac/fsl_ddr_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c index 3745eec67335..c505fb268474 100644 --- a/drivers/edac/fsl_ddr_edac.c +++ b/drivers/edac/fsl_ddr_edac.c @@ -599,7 +599,7 @@ int fsl_mc_err_probe(struct platform_device *op) /* register interrupts */ pdata->irq = platform_get_irq(op, 0); - res = devm_request_irq(&op->dev, pdata->irq, + res = request_irq(pdata->irq, fsl_mc_isr, IRQF_SHARED, "[EDAC] MC err", mci); @@ -635,6 +635,7 @@ void fsl_mc_err_remove(struct platform_device *op) if (edac_op_state == EDAC_OPSTATE_INT) { ddr_out32(pdata, FSL_MC_ERR_INT_EN, 0); + free_irq(pdata->irq, mci); } ddr_out32(pdata, FSL_MC_ERR_DISABLE, -- 2.55.0