Re: [PATCH] EDAC/mpc85xx: don't use devm for request_irq()

Borislav Petkov <[email protected]> Thu, 30 Jul 2026 19:15:28 -0700
Newsgroups org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel
Message-ID <20260731021528.GMamwFQMXHuufR64w7@fat_crate.local>
On Thu, Jul 30, 2026 at 06:12:13PM -0700, Rosen Penev wrote:
> Use modern irq acquisition APIs to avoid having to call
> irq_dispose_mapping() since there's no real need to copy the mapping.
> 
> Use non devm version of request_irq() as IRQ need to be freed before
> edac_device_del_device() to avoid a use after free issue.
> 
> Signed-off-by: Rosen Penev <[email protected]>
> ---
>  drivers/edac/mpc85xx_edac.c | 25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)

You were on the thread where we orphaned that driver because we have no hw to
test it on, right?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette