Re: [PATCH] EDAC/mpc85xx: don't use devm for request_irq()

Rosen Penev <[email protected]> Thu, 30 Jul 2026 20:56:56 -0700

Newsgroups	org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel
Message-ID	<CAKxU2N-_RnBtiEhFaKL1Yzv6HSv+m0H16-cTFaLrgL_u8kcbaw@mail.gmail.com>

On Thu, Jul 30, 2026 at 7:15=E2=80=AFPM Borislav Petkov <[email protected]> wrot=
e:
>
> On Thu, Jul 30, 2026 at 06:12:13PM -0700, Rosen Penev wrote:
> > Use modern irq acquisition APIs to avoid having to call
> > irq_dispose_mapping() since there's no real need to copy the mapping.
> >
> > Use non devm version of request_irq() as IRQ need to be freed before
> > edac_device_del_device() to avoid a use after free issue.
> >
> > Signed-off-by: Rosen Penev <[email protected]>
> > ---
> >  drivers/edac/mpc85xx_edac.c | 25 ++++++++++++++++++-------
> >  1 file changed, 18 insertions(+), 7 deletions(-)
>
> You were on the thread where we orphaned that driver because we have no h=
w to
> test it on, right?
yes.

For whatever reason, sashiko flagged this in a different driver

https://sashiko.dev/#/patchset/20260719194009.117532-1-rosenp%40gmail.com
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette