Re: [PATCH] EDAC/fsl_ddr: use non devm for request_irq()
Frank Li <[email protected]> Fri, 31 Jul 2026 10:12:07 -0500
| Newsgroups | org.kernel.vger.linux-edac,dev.linux.lists.imx,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <amy7R6W5aJ58t6fy@SMW015318> |
On Thu, Jul 30, 2026 at 05:44:34PM -0700, Rosen Penev wrote: > On Thu, Jul 30, 2026 at 5:37 PM Borislav Petkov <[email protected]> wrote: > > > > On Thu, Jul 30, 2026 at 05:16:11PM -0700, Rosen Penev wrote: > > > > here already disable hardware irq. Just call > > > > synchronize_irq() to make sure pending irq handled. > > > AI disagrees with this suggestion: > > > > How about you try to parse what AI says and verify it yourself? > Makes sense to me. > > The alternative is to use devm_add_action_or_reset for edac_mc_free. > I'd rather not do that. This one should work, of add devm_edac_add*() version to simplufy probe and beanfit other EDAC driver. Frank > > > > -- > > Regards/Gruss, > > Boris. > > > > https://people.kernel.org/tglx/notes-about-netiquette