Re: [PATCH] EDAC/fsl_ddr: use non devm for request_irq()

Rosen Penev <[email protected]> Fri, 31 Jul 2026 10:33:37 -0700
Newsgroups org.kernel.vger.linux-edac,dev.linux.lists.imx,org.kernel.vger.linux-kernel
Message-ID <CAKxU2N-KCz2UAKY77fUb9G_ReV-yRJhZogcZkvL4N_N6nrGWnw@mail.gmail.com>
On Fri, Jul 31, 2026 at 8:12=E2=80=AFAM Frank Li <[email protected]> wro=
te:
>
> On Thu, Jul 30, 2026 at 05:44:34PM -0700, Rosen Penev wrote:
> > On Thu, Jul 30, 2026 at 5:37=E2=80=AFPM Borislav Petkov <[email protected]> =
wrote:
> > >
> > > On Thu, Jul 30, 2026 at 05:16:11PM -0700, Rosen Penev wrote:
> > > > > here already disable hardware irq. Just call
> > > > > synchronize_irq() to make sure pending irq handled.
> > > > AI disagrees with this suggestion:
> > >
> > > How about you try to parse what AI says and verify it yourself?
> > Makes sense to me.
> >
> > The alternative is to use devm_add_action_or_reset for edac_mc_free.
> > I'd rather not do that.
>
> This one should work, of add devm_edac_add*() version to simplufy probe a=
nd
> beanfit other EDAC driver.
That's probably appropriate.
>
> Frank
>
> > >
> > > --
> > > Regards/Gruss,
> > >     Boris.
> > >
> > > https://people.kernel.org/tglx/notes-about-netiquette