[PATCHv2 0/4] EDAC/altera: Address sashiko reviews part 1(v2)
Dinh Nguyen <[email protected]>
| Newsgroups | org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi EDAC maintainers, This is version 2 of the patch series that addresses some of the sashiko reviews for the Altera EDAC driver. I apologize for the lateness of this series, but I do believe these 4 patches are important enough to be included in v7.2 because they are confirmed bug hits. patch 1/4 : EDAC/altera: Add suppress_bind_attrs so driver cannot get unbound While sashiko did not flag this specific feature of the driver, the reviews caused me to look at the bind/unbind feature of this driver. The unbind/bind feature will absolutely cause a system to crash because during the bind, the driver sets a bit to clear the memory. We absolutely cannot do this on a running system. patch 2/4 : EDAC/altera: Drop __init from ECC setup paths for re-probe safety For all the different child nodes of the main EDAC module, there is a chance for deferred probing. If EPROBE_DEFER occurs, and these functions that are marked with __init will be freed. patch 3/4 : EDAC/altera: Fix code leak on dci allocation failure The dci data structure is leaked if a devres_open_group() fails. patch 4/4 : EDAC/altera: Fix use-after-free in error paths The dci structure cannot be freed before the unregistering of the interrupts. Dinh Nguyen (4): EDAC/altera: Add suppress_bind_attrs so driver cannot get unbound EDAC/altera: Drop __init from ECC setup paths for re-probe safety EDAC/altera: Fix code leak on dci allocation failure EDAC/altera: Fix use-after-free in error paths drivers/edac/altera_edac.c | 60 ++++++++++++++++++-------------------- 1 file changed, 29 insertions(+), 31 deletions(-) -- 2.42.0.411.g813d9a9188