[PATCH 0/1] EDAC/altera: Guard against NULL of_node

Dinh Nguyen <[email protected]>
Newsgroups org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi EDAC maintainers,

I wanted to explain the reason why I think this patch doesn't need a
Fixes tag. The way the Altera EDAC is written there are many instances
of the driver referencing the of_node, which is why they are flagged in
many sashiko reviews.

This patch checks for those NULL of_node in the probe functions using
dev_of_node() so we don't have to guard the of_node in all the other
functions.

The reason we don't need the Fixes tag is because this system is
supposed to run with CONFIG_OF enabled. The system would fail way
before it gets to this driver if an of_node is not found. Thus I don't
see a need for a Fixes tag but the guard should be in place for
completeness.

Thanks,

Dinh Nguyen (1):
  EDAC/altera: Guard against NULL of_node pointer dereference

 drivers/edac/altera_edac.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

-- 
2.42.0.411.g813d9a9188
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.