[PATCH 3/4] EDAC/versalnet: use put_device() on device_register() failure
Tarun Sahu <[email protected]>
| Newsgroups | org.kernel.vger.linux-edac,dev.linux.lists.driver-core,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
When device_register() fails, calling kfree(dev) directly bypasses the device_release() callback (versal_edac_release) and leaks the allocated driver core structures. Fix this by calling put_device(dev) when device_register() returns an error, ensuring proper refcount decrement and release cleanup. Signed-off-by: Tarun Sahu <[email protected]> --- drivers/edac/versalnet_edac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index 97ec05d68bbb..2912b3658915 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -829,8 +829,10 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i dev->release = versal_edac_release; rc = device_register(dev); - if (rc) + if (rc) { + put_device(dev); goto err_mc_free; + } mci->pdev = dev; mc_init(mci, dev); @@ -852,9 +854,9 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i device_unregister(mci->pdev); err_mc_free: edac_mc_free(mci); + return rc; err_dev_free: kfree(dev); - return rc; } -- 2.55.0.679.g6767b8d81c-goog