[PATCH 0/7] Add Aspeed AST2700 SDRAM EDAC support
Ryan Chen <[email protected]>
| Newsgroups | org.kernel.vger.linux-edac,dev.linux.lists.linux-rt-devel,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.stable,org.ozlabs.lists.linux-aspeed |
|---|---|
| Message-ID | <[email protected]> |
Add ECC error reporting for the Aspeed AST2700 SoC to the existing aspeed_edac driver. The AST2700 memory controller keeps the same overall EDAC programming model as the earlier Aspeed BMC SoCs, but uses a different register layout, a split interrupt status/clear/mask scheme and DDR4/DDR5 memory. Rather than fork the driver, the existing code is first tidied and generalised, then the AST2700 is added as one more per-SoC variant. The series is organised as: - dt-bindings: document the new "aspeed,ast2700-sdram-edac" compatible; - set dimm->grain to the controllers' ECC granularity, fixing a pre-existing WARN_ON in the EDAC core on the first reported error (carries a Fixes: tag and Cc: stable); - clean up whitespace and include ordering so the following changes start from a consistent style; - free the mem_ctl_info unconditionally on remove, dropping a NULL check on a value that cannot be NULL there; - drop the regmap, which serves only as an MMIO wrapper here, in favour of direct readl()/writel() under an explicit raw spinlock, annotating the register base with __guarded_by() so that the locking is checked at build time under CONFIG_WARN_CONTEXT_ANALYSIS; - abstract the SoC-specific details (register layout, ECC/DRAM-type bits, memory types, write-protection key) behind per-SoC chip data; - add the AST2700 support, teaching the shared error-reporting helpers to report an error without an address for its single shared failure-address register. Tested with the memory controller's ECC error injection on both an existing SoC and the new one: - AST2600: an injected correctable error is reported through the EDAC interface as a CE with the recorded failure address, confirming the regmap removal and the chip-data refactor do not regress the existing controllers. - AST2700: an injected correctable error is likewise reported as a CE with the expected failure address. Signed-off-by: Ryan Chen <[email protected]> --- Ryan Chen (7): dt-bindings: edac: aspeed: Add AST2700 SDRAM EDAC EDAC/aspeed: Set the DIMM grain EDAC/aspeed: Clean up whitespace and include ordering EDAC/aspeed: Free the mem_ctl_info unconditionally on remove EDAC/aspeed: Replace regmap with direct register access EDAC/aspeed: Abstract SoC differences behind chip data EDAC/aspeed: Add AST2700 support .../bindings/edac/aspeed,ast2400-sdram-edac.yaml | 6 +- drivers/edac/aspeed_edac.c | 414 +++++++++++++-------- 2 files changed, 268 insertions(+), 152 deletions(-) --- base-commit: 5464985e42c04e335fb30e38fbc409c997db9bec change-id: 20260625-edac-8e960e02e7f7 Best regards, -- Ryan Chen <[email protected]>