Re: [PATCH v16 29/38] x86/tpm: Early startup TPM PCR extending driver
Dave Hansen <[email protected]> Fri, 15 May 2026 15:32:13 -0700
| Newsgroups | org.kernel.vger.linux-efi,dev.linux.lists.iommu,org.infradead.lists.kexec,org.kernel.vger.linux-crypto,org.kernel.vger.linux-doc,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 5/15/26 14:14, Ross Philipson wrote: > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Based of the original tpm_tis.c implementation as found in the > + * Linux 2.6 code base. > + * > + * Copyright (C) 2005, 2006 IBM Corporation > + * > + * Authors: > + * Leendert van Doorn <[email protected]> > + * Kylene Hall <[email protected]> > + */ Hey guys, Last time: > https://lore.kernel.org/lkml/[email protected]/ So, fast forward another version and six months ... the "fishy" bits ripped out of it, license changed and ... crickets in the changelogs and cover letter from what I can see. Second, the cadence on these is rather slow. I don't know what the delta from the last one is, but it doesn't _look_ like a six month project. It's really hard for reviewers to page stuff back in after that long. Also, new since the last post, you got Sashiko'd: > https://sashiko.dev/#/patchset/20260515211410.31440-1-ross.philipson%40gmail.com I'd suggest working through those first before the maintainers take another crack at this. There are a *LOT* of comments in there. I'd appreciate if you'd go back through the v15 comments and make sure you got all of them. I certainly felt like you didn't address at least on of my questions (the licensing stuff).