Re: [PATCH v5] selftest: size: Add size test for Linux kernel
Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/[email protected]>
| Newsgroups | org.kernel.vger.linux-embedded,org.kernel.vger.linux-api,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Michael, Tim, On Wed, 03 Dec 2014 14:43:11 +1100, Michael Ellerman wrote: > > diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile > > new file mode 100644 > > index 0000000..47f8e9c > > --- /dev/null > > +++ b/tools/testing/selftests/size/Makefile > > @@ -0,0 +1,15 @@ > > +#ifndef CC > > + CC = $(CROSS_COMPILE)gcc > > +#endif > > I think the following is preferable: > > CC := $(CROSS_COMPILE)$(CC) It is even more necessary that #ifndef and #endif don't exist in make. They are just comments, and therefore, ignored. Seems like Tim does too much C :-) Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com