Re: [PATCH] tools: fix cross-compile var export
Martin Kelly <[email protected]>
| Newsgroups | org.kernel.vger.linux-embedded,org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 01/07/2018 11:04 AM, Paul Gortmaker wrote: > [Re: [PATCH] tools: fix cross-compile var export] On 07/01/2018 (Sun 10:31) Martin Kelly wrote: > > [...] > >> With the change, we add do CC = $(CROSS_COMPILE)gcc if and only if CC is not >> already set. I'm happy to add all these details to the commit description. > > That is probably a step in the right direction. I contribute to yocto > on a regular basis and hence am sympathetic to these frustrating SDK > type issues. But after a quick scan of this patch it wasn't obvious to > me that existing behaviour was preserved, or that it would be a pain to > separate it into chunks. (key word here being "quick") > > So I'd recommend updating the commit log, and adding a Cc: line for the > maintainers of each subsystem below, and then if nobody complains you > might get akpm to pick it up as he does for other patches w/o a clear > maintainer or subsystem. > > P Thanks, I have done so. I also contribute to Yocto and indeed, SDK issues are all-to-common.