Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages
Robin Murphy <[email protected]> Thu, 1 Apr 2021 12:28:11 +0100
| Newsgroups | org.kernel.vger.linux-embedded,dev.linux.lists.iommu,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 2021-04-01 10:39, Geert Uytterhoeven wrote: > Hi Steven, > > On Wed, Mar 31, 2021 at 3:40 PM Steven Rostedt <[email protected]> wrote: >> On Wed, 31 Mar 2021 11:31:03 +0200 >> Geert Uytterhoeven <[email protected]> wrote: >> >>> This reduces kernel size by ca. 0.5 KiB. >> >> If you are worried about size, disable tracing and it will go away >> entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in >> size overhead. > > Fair enough for this particular case, as tracing can be disabled. I think the same argument can be applied to patch #1 - it's hard to imaging anyone debugging an IOMMU driver on a system where a few hundred bytes makes the slightest bit of difference, and for people not debugging IOMMU drivers it should be moot (per the message itself). Robin.