Re: [PATCH 1/1] drivers: misc: add driver for bootstage stash

Hello Krzysztof,

On Friday, 23 May 2025 at 08:29:28 Krzysztof Kozlowski <[email protected]> wrote:
> On 23/05/2025 00:42, Francesco Valla wrote:
> > Add support for bootstage stash areas containing boot time data
> > created by some bootloader (e.g. U-Boot). The driver provides generic
> > time information through sysfs and platform-specific one through
> > debugfs.
> > 
> > Signed-off-by: Francesco Valla <[email protected]>
> 
> Your Cc list is so incomplete I really do not understand which project
> you target and this popped up in my lei filters. If this is not for
> Linux kernel, please ignore the rest.
> 

Yes, target is the Linux kernel, the patch contains a mock-up driver
generated by a discussion [1] of the Boot Time SIG held on last Tuesday.
I should have marked it as proof-of-concept rather than RFC, probably.

> If this is for Linux kernel then:
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
> 

The only warning, if we ignore three on unnecessary parentheses raised
by --strict, is the one about the DT bindings that need to be submitted
separately. That was expected and somewhat specified in the cover letter,
but I honestly did not think of the automated tooling.

> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> 

I used scripts/get_maintainer.pl in the past but I wasn't aware of this
use of b4. I'll check it out.

> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
> 
> Please kindly resend and include all necessary To/Cc entries.
> 


I did not want to unnecessary bother people that might not be interested,
as the current form is not intended for mainline. I'll however be more
scrupulous in the future.

> 
> Best regards,
> Krzysztof
> 
> 

Thank you for the guidance!

Regards,
Francesco

[1] https://docs.google.com/document/d/1XAufoTT6VVJOTMzKMoz8SyOss-JA9H4J1_yVXQq5mN0/edit?tab=t.0