Re: [PATCH RFC 0/3] Add splash DRM client
Mario Limonciello <[email protected]> Tue, 28 Oct 2025 08:39:09 -0500
| Newsgroups | org.kernel.vger.linux-embedded,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 10/28/25 3:09 AM, Francesco Valla wrote: > Hi, > > On Monday, 27 October 2025 at 18:19:12 Maxime Ripard <[email protected]> wrote: >> On Mon, Oct 27, 2025 at 11:31:06AM -0500, Mario Limonciello wrote: >>> On 10/27/25 11:28 AM, Maxime Ripard wrote: >>>> On Mon, Oct 27, 2025 at 11:01:55AM -0500, Mario Limonciello wrote: >>>>> On 10/27/25 7:35 AM, Thomas Zimmermann wrote: >>>>>>>> - a very simple progress bar, which can be driven through sysfs; >>>>>> >>>>>> Once you have options to control these settings from user space, you >>>>>> should do it in user space entirely. As Maxime suggested, please improve >>>>>> plymouth for anything with animation. >>>>>> >>>>>>>> - a static image (optional). >>>>>> >>>>>> Board vendors often provide an image, see /sys/firmware/acpi/bgrt/. This >>>>>> is a candidate for display, or the penguin or a custom image. Please >>>>>> make it configurable by Kconfig. Again, if you need policy and >>>>>> heuristics for deciding what to display, you better do this in user >>>>>> space. >>>>> >>>>> I'd actually argue that the static image from BGRT should be the preferred >>>>> priority. This can make for a nice hand off to Plymouth. >>>>> >>>>> The (UEFI) BIOS already will show this image as soon as the GOP driver is >>>>> loaded. Bootloaders like GRUB by default will avoid showing anything or >>>>> will overwrite with the exact same image in the same location. This can let >>>>> the kernel do the same, and then the moment Plymouth takes over it could do >>>>> the same. >>>> >>>> And BGRT isn't typically found on embedded systems at all, so I'm not >>>> sure it's a sensible default, let alone a priority. At most a possible >>> >>> There are certainly embedded machines using UEFI and that have a BGRT. >> >> Yes, indeed, hence the "typically". >> >>> How about "Sensible default the top of the priority list if it exists" >> >> How about we don't tell contributors what their priorities must be? >> >> Maxime >> > > I'm not familiar at all with BGRT, I'll study a bit about it. > > A build-time configuration could then let the user select: > > - a plain solid color > - a custom static image > - the penguin logo (?) > - (on UEFI systems) BGRT source Thanks! What I had in mind (which feel free to disagree - it's an RC afterall): User can pick one of these: CONFIG_SPLASH_IMAGE CONFIG_SPLASH_COLOR If user picks CONFIG_SPLASH_IMAGE then the default behavior would be UEFI BGRT with a fallback to a Linux penguin. Additionally there could be a CONFIG_SPLASH_CUSTOM_IMAGE This would populate the path to a custom image at build time. If user picks this then it would override both UEFI BGRT and Linux penguin. > > > > Thank you > > Regards, > Francesco