Re: [PATCH v7 05/11] fstests: verify fanotify isolation on cloned filesystems
Anand Suveer Jain <[email protected]>
| Newsgroups | org.kernel.vger.linux-ext4,net.sourceforge.lists.linux-f2fs-devel,org.kernel.vger.fstests,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
>> +. ./common/preamble
>> +
>> +_begin_fstest auto quick mount clone
>> +
>> +_require_test
>> +_require_block_device $TEST_DEV
>> +_require_loop
>> +_require_command "$FSNOTIFYWAIT_PROG" fsnotifywait
>> +_require_unique_f_fsid
>> +
>> +_cleanup()
>> +{
>> + cd /
>> + [[ -n $pid1 ]] && { kill -TERM "$pid1" 2> /dev/null; wait $pid1; }
>> + [[ -n $pid2 ]] && { kill -TERM "$pid2" 2> /dev/null; wait $pid2; }
>> +
>> + if [ "$semanage_added" = "yes" ]; then
>> + semanage permissive -d unconfined_t >/dev/null 2>&1 || true
>
> Needs to _require_command semanage, because it's not otherwise required
> by fstests. Otherwise looks ok to me.
>
Oh right. Added
In the new patch:
diff --git a/common/config b/common/config
::
+export SEMANAGE_PROG="$(type -P semanage)"
In this patch:
diff --git a/tests/generic/801 b/tests/generic/801
::
+_require_command "$SEMANAGE_PROG" semanage