Re: [PATCH] ext4: propagate errors from fast commit range replay
"Theodore Ts'o" <[email protected]>
| Newsgroups | org.kernel.vger.linux-ext4,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <178481171746.796182.106726034351899659.b4-ty@b4> |
On Wed, 08 Jul 2026 08:12:04 +0000, Guanghui Yang wrote:
> ext4_fc_replay() stops replaying fast commit tags only when a tag
> handler returns a negative error. However, ext4_fc_replay_add_range()
> and ext4_fc_replay_del_range() currently return 0 from their common
> exit paths even after internal failures.
>
> This hides errors from ext4_fc_record_modified_inode(),
> ext4_map_blocks(), ext4_find_extent(), ext4_ext_insert_extent(),
> ext4_ext_replay_update_ex(), and ext4_ext_remove_space(). As a result,
> a failed ADD_RANGE or DEL_RANGE replay can be treated as successful and
> the replay code may continue with subsequent fast commit tags.
>
> [...]
Applied, thanks!
[1/1] ext4: propagate errors from fast commit range replay
commit: d8b8dd3530bf41e14b118702cdaf9de64bb96885
Best regards,
--
Theodore Ts'o <[email protected]>