Re: [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw

Carlos Maiolino <[email protected]> Fri, 24 Jul 2026 14:47:58 +0200
Newsgroups org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-xfs
Message-ID <[email protected]>
On Thu, Jul 23, 2026 at 12:08:21PM -0400, Theodore Tso wrote:
> On Thu, Jul 23, 2026 at 08:10:21AM -0500, Darrick J. Wong wrote:
> > > Yes.  Sashiko also reported that yesterday and I replied with a patch,
> > > but I now noticed the report and thus my reply only went to me,
> > > a sashiko-review list and Ted, but not everone else or the lists.
> > > 
> > > WTF?
> > 
> > Sashiko doesn't email the lists by default, and I don't think we want to
> > turn that on for the fsdevel firehose.
> 
> Whether or not the review goes to a mailing list is up to each
> subsystem to determine.  Some people have violently objected to the
> review going to the mailing list, which is why it's optional.
> 
> I have asked to have ext4 reviews to be cc'ed to the linux-ext4
> list[1].  It would be up to the VFS maintainers whether or not we want
> to enable it for linux-fsdevel.
> 
> [1] https://github.com/sashiko-dev/sashiko/pull/365
> 
> The XFS maintainers can request if patches cc'ed to linux-fs should
> get reviewed and sent back to authors and/or the maintainers and/or
> the linux-fs mailing list.  You can either ask the Sashiko devs to
> edit the email_policy.toml file, or you can send a pull request yourself.
> 

IIRC the discussion we had a while back was to keep the reviews emailed
to authors only...

Now I wonder how feasible would be to have a "linux-xfs-review" list to
send sashiko reviews to, then people opt-in to it? Would it be overkill?