Re: [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw

On Fri, Jul 24, 2026 at 02:39:49PM -0700, Joanne Koong wrote:
> > > -     ret = iomap_dio_rw(iocb, to, &ext4_iomap_ops, NULL, 0, NULL, 0);
> > > +     ret = iomap_dio_read_simple(iocb, to, ext4_iomap_begin);
> >
> > I was kinda wondering if you can pass ext4_iomap_ops.iomap_begin here
> > to avoid the declaration in ext4.h?
> 
> I think it ends up being a bit cleaner to do it here, otherwise the
> subsequent ext4 patch that replaces .iomap_begin()/.iomap_end() with
> .iomap_next() will have to do it.

Yes, we'd just do the work twice otherwise.