Re: [PATCH 1/1] ext4: fix incorrect function call when initializing s_resgid

Ritesh Harjani (IBM) <[email protected]> Tue, 28 Jul 2026 10:10:07 +0530
Newsgroups org.kernel.vger.linux-ext4,org.kernel.vger.linux-kernel,org.kernel.vger.stable
Message-ID <[email protected]>
Jiazi Liu <[email protected]> writes:

> In __ext4_fill_super(), s_resgid is initialized by calling
> ext4_get_resuid() instead of ext4_get_resgid(), resulting in the
> reserved GID being set to the same value as the reserved UID rather
> than the value stored in the superblock.
>
> Fixes: 12c84dd4d308 ("ext4: add support for 32-bit default reserved uid and gid values")
> Cc: [email protected]
> Signed-off-by: Jiazi Liu <[email protected]>

yup, that clearly looks like a simple miss. 

Nice catch! Wondering whether this was caught by code review or did you
hit an issue due to this?

Looks good to me. Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <[email protected]>