Re: [PATCH v5 0/20] fs: Fix missed inode write during fsync

On Mon 27-07-26 17:51:56, Christian Brauner wrote:
> On Mon, 27 Jul 2026 12:49:18 +0200, Jan Kara wrote:
> > fs: Fix missed inode write during fsync
> > 
> > Hello,
> > 
> > here is v5 of the patch series which fixes the possibly missing inode write
> > during fsync(2) for filesystems using generic metadata bh tracking. This
> > revision contains mostly small fixes and improvements since v3, neither
> > Sashiko nor Christian found fundamental issues with this approach.
> > 
> > [...]
> 
> I've put three patches on top of vfs-7.3.sync that fix Sashiko reported
> bugs. @Jan, please take a look. If that looks fine to you I can fold
> them down.

Thanks! I went through all the Sashiko comments and the (now 4) patches you
have on top are the only issues I have found valid among Sashiko reviews as
well. The fixes look good, thanks for writing them! Feel free to fold them
or leave them at the end of the series whatever is more convenient for you.

								Honza

> 
> ---
> 
> Applied to the vfs-7.3.sync branch of the vfs/vfs.git tree.
> Patches in the vfs-7.3.sync branch should appear in linux-next soon.
> 
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
> 
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
> 
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs-7.3.sync
> 
> [01/20] affs: Drop support for metadata bh tracking
>         https://git.kernel.org/vfs/vfs/c/b637f52f2f26
> [02/20] fs: Fix possible UAF in mark_buffer_write_io_error()
>         https://git.kernel.org/vfs/vfs/c/b0bca4e95b03
> [03/20] fs: Fix missed inode writeback when racing with __writeback_single_inode
>         https://git.kernel.org/vfs/vfs/c/5a499dad2c79
> [04/20] ext4: Allocate mapping_metadata_bhs struct on demand
>         https://git.kernel.org/vfs/vfs/c/daca0f43a934
> [05/20] fs: Provide way for filesystem to wait for metadata writeback
>         https://git.kernel.org/vfs/vfs/c/c474bc56b6d1
> [06/20] ext2: Fix lost inode updates for IS_SYNC inodes
>         https://git.kernel.org/vfs/vfs/c/356984d1a5c3
> [07/20] ext2: Drop __ext2_write_inode()
>         https://git.kernel.org/vfs/vfs/c/4efd6a43a92f
> [08/20] ext2: Avoid unnecessary inode buffer writeback for sync(2)
>         https://git.kernel.org/vfs/vfs/c/74d4faaa76b8
> [09/20] ext2: Fix data integrity writeout issues
>         https://git.kernel.org/vfs/vfs/c/917e583992e5
> [10/20] udf: Fix data integrity writeout issues
>         https://git.kernel.org/vfs/vfs/c/1ec98214ccf0
> [11/20] udf: Use sync_inode_metadata() to writeout IS_SYNC inode
>         https://git.kernel.org/vfs/vfs/c/061d83911da5
> [12/20] udf: Drop udf_sync_inode()
>         https://git.kernel.org/vfs/vfs/c/c87c0098cf61
> [13/20] udf: Use sync_inode_metadata() in udf_evict_inode()
>         https://git.kernel.org/vfs/vfs/c/e0e30479c756
> [14/20] udf: Fold udf_update_inode() into udf_write_inode()
>         https://git.kernel.org/vfs/vfs/c/5b2e45c33565
> [15/20] bfs: Fix data integrity writeout issues
>         https://git.kernel.org/vfs/vfs/c/0cee81a3fd9f
> [16/20] minix: Fix data integrity writeout issues
>         https://git.kernel.org/vfs/vfs/c/84af7c3b3462
> [17/20] ext4: Fix data integrity writeout issues in nojournal mode
>         https://git.kernel.org/vfs/vfs/c/c26339e1df33
> [18/20] fat: Fix missed inode writeback during fsync(2)
>         https://git.kernel.org/vfs/vfs/c/525da4f40a7c
> [19/20] fat: Replace fat_sync_inode() with sync_inode_metadata()
>         https://git.kernel.org/vfs/vfs/c/e668e0668181
> [20/20] vfs: Remove mmb_fsync()
>         https://git.kernel.org/vfs/vfs/c/dc78399717c4
> 
-- 
Jan Kara <[email protected]>
SUSE Labs, CR