Re: [PATCH] ext4: Avoid entering writeback paths during fastcommit replay

On Thu 06-08-26 10:48:47, Theodore Tso wrote:
> On Tue, Aug 04, 2026 at 12:41:13PM -0500, Jan Kara wrote:
> > Fastcommit replay effectively happens in nojournal mode. This results in
> > ext4_mark_iloc_dirty() setting I_METADATA_WRITEBACK flag and as a result
> > we end up entering filesystem writeback functions. However during
> > fastcommit replay s_writepages_rwsem isn't initialized yet and hence we
> > crash.
> > 
> > Fix the problem by avoiding setting I_METADATA_WRITEBACK during
> > fastcommit replay. Journal replay flushes the whole block device after
> > replay anyway so all metadata is properly persisted and replay is faster
> 
> It looks like this patch is only applicable if the patch series "fs:
> Fix missed inode write during fsync" is applied, and in fact appears
> to fix a problem introduced in "[PATCH v5 17/20] ext4: Fix data
> integrity writeout issues in nojournal mode"?

Right, yes, it's meant for Christian to pick this patch up to his tree.

								Honza
-- 
Jan Kara <[email protected]>
SUSE Labs, CR