Re: [PATCH v12 00/11] Data in direntry (dirdata) feature

On Aug 2, 2026, at 03:39, Artem Blagodarenko <[email protected]> wrote:
> 
>  Sashiko flagged 29 potential issues across the v12 series. I have gone
>  through all of them.
> 
>  The vast majority are false positives. The most common causes:
> 
>  - Sashiko reviewed intermediate patch states rather than the final
>  committed code (reported build failures and missing updates that do
>  not exist in the submitted series).
>  - Findings about clearing EXT4_DIRENT_LUFID without compacting
>  remaining extensions: ext4_setent_compact_exts() in patch 10 does
>  exactly this before the flag is cleared.
>  - Several findings concern pre-existing issues in make_indexed_dir(),
>  dx_release(), and the htree checksum paths that are not introduced
>  by this series.
>  - The silent-rename concern for encrypted+casefolded directories in
>  SET_LUFID: ext4_fname_setup_filename() normalizes the plaintext
>  before encrypting, so different-case input produces the same
>  ciphertext.
> 
>  If any small issues remain after this analysis they can be addressed
>  in the normal review round with developers.
> 
>  The series is ready for review. I would appreciate a look from the
>  ext4 maintainers.

Hi Ted, Jan,
I think that several of the early patches in this series are just code
cleanups before the main feature implementation and could be reviewed
and landed with fairly low effort.  That would help reduce the number
of patches that need to be rebased and posted each time to the list.

> Artem Blagodarenko (11):
>  ext4: validate count against limit in ext4_dx_csum_verify/_set

This is a bugfix for bad on-disk data.

>  ext4: replace ext4_dir_entry with ext4_dir_entry_2
>  ext4: add ext4_dir_entry_is_tail()
  
These are code cleanups in preparation for the main feature but do
not affect normal operations.

> ext4: add dirdata format definitions and access helpers

This one is reserving code points for the dirdata feature (unused).

>  ext4: refactor dx_root to support variable dirent sizes

This is also a code reorg that doesn't affect current functionality,
but a bit more involved than the previous ones in terms of changes.

>  ext4: add ext4_dir_entry_len()
>  ext4: rename ext4_dir_rec_len() and clarify dirdata usage

These ones are also code reorg/cleanup. 

>  ext4: dirdata feature

The first one is the main functionality of the dirdata feature,
which would need the most review.  While the core of this code
has been used for many years, it has needed some changes to work
with the fscrypt+casefold feature.

>  ext4: add dirdata LUFID support for directory entry rename

This is also part of the main feature, but is split out to reduce
the initial patch size since it is somewhat isolated.

>  ext4: add dirdata set/get helpers
>  ext4: Add EXT4_IOC_SET_LUFID ioctl for setting LUFID on directory
>    entries

These ones are adding the test interface.

Cheers, Andreas