Re: [PATCH -next v5 14/32] ext4: do not use data=ordered mode for inodes using buffered iomap path
| Newsgroups | org.kernel.vger.linux-ext4 |
|---|---|
| Message-ID | <[email protected]> |
> From: Zhang Yi <[email protected]> > > The data=ordered mode introduces two fundamental conflicts with the > iomap buffered write path, leading to potential deadlocks. > > 1) Lock ordering conflict > In the iomap writeback path, each folio is processed sequentially: > the folio lock is acquired first, followed by starting a transaction > to create block mappings. > > In data=ordered mode, writeback triggered by the journal commit > process may attempt to acquire a folio lock that is already held by > iomap background writeback process. Meanwhile, iomap, under that same > folio lock, may start a new transaction to map other blocks on this > folio and wait for the currently committing transaction to finish, > [ ... ] > > Online defragmentation does not yet support iomap; this can be resolved > separately in the future. > > Signed-off-by: Zhang Yi <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=14