Re: [PATCH -next v5 09/32] ext4: avoid unnecessary transaction in ext4_map_blocks() for unwritten extents
| Newsgroups | org.kernel.vger.linux-ext4 |
|---|---|
| Message-ID | <[email protected]> |
> From: Zhang Yi <[email protected]> > > When ext4_map_blocks() finds an unwritten extent in the extent cache and > the caller is willing to accept unwritten extents without conversion, > there is no need to start a journal transaction since no metadata update > is required. This avoids unnecessary transaction overhead in the > upcoming iomap writeback path when overwriting already-allocated > unwritten extents. > > One thing to be careful about, as the comment in ext4_map_blocks() > states, if the flags contain EXT4_GET_BLOCKS_CREATE, the function will > mark @map as mapped. > > Signed-off-by: Zhang Yi <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9