Re: [PATCH] Add EXT4_STATE_MAY_INLINE_DATA check in ext4_readdir

On Fri, Aug 14, 2026 at 09:57:33AM -0400, Theodore Tso wrote:
> On Fri, Aug 14, 2026 at 04:40:02PM -0500, shuo chen wrote:
> > Because ext4_convert_inline_data_nolock() has already called
> > ext4_destroy_inline_data_nolock(), the inode is no longer in the inline
> > state. So we need ext4_create_inline_data() to rebuild the inline state.
> 
> There are other ways to restore the inline state than calling ext4_create_inline_data().
I get it — keep a backup of the inode and restore on rollback.
But I prefer your second (safer) approach — allocate first, then convert.
I'll send a v2 following that.
> 
> Cheers,
> 
> 					- Ted