Re: [PATCH] staging: sm750fb: fix CamelCase variable name Bpp to bpp
Ahmet Sezgin Duran <[email protected]>
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 6/11/26 1:37 PM, Siddhesh Sable wrote: > CamelCase variable names violate the kernel coding style guidelines. > Rename all occurrences of 'Bpp' to 'bpp' to fix checkpatch warnings. > > Signed-off-by: Siddhesh Sable <[email protected]> > --- > drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) Still not okay. You need to: * Send a new revision as V2,V3,V4,etc for changes and describe them. * Wait at least a day to send a new revision. * Make sure that your patch actually applies. Currently it doesn't apply to Greg's latest staging-testing branch. Even better, have a look at Dan Carpenter's blog post about this: https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Regards, Ahmet Sezgin Duran