Re: [PATCH] staging: fbtft: use %pe for backlight errors
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAHp75VfSUfjo6rxUdwMghZb7V9s2_AgYCDex5uDX3cCWZOenyg@mail.gmail.com> |
On Sun, Jun 14, 2026 at 11:08 PM Keefe Reeves <[email protected]> wrote: > > From: Keefe Reeves <[email protected]> > > Coccinelle found two places where backlight registration errors are > printed by passing PTR_ERR() to dev_err(). > > Use %pe instead so the error pointer can be printed directly. This keeps > the behavior the same and just makes the error printing cleaner. > > Signed-off-by: Keefe Reeves <[email protected]> I see a subtle problem with this email address. In case something happened with your contribution (exempli gratia a regression found) there will be no possibility to contact you without digging into mailing list archives to get your Gmail address. I would prefer to see the From: and SoB to acce-pt responses. For the change itself, I have no objections. If one considers this useful (probably to stop flood of the similar patches in the future) Reviewed-by: Andy Shevchenko <[email protected]> -- With Best Regards, Andy Shevchenko