Re: [PATCH v2 3/4] drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support
Markus Elfring <[email protected]>
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
… > +++ b/drivers/gpu/drm/solomon/ssd130x.c > @@ -146,6 +146,33 @@ > #define SSD133X_COLOR_DEPTH_256 0x0 > #define SSD133X_COLOR_DEPTH_65K 0x1 > > +/* ssd135x commands */ > +#define SSD135X_SET_COL_RANGE 0x15 > +#define SSD135X_WRITE_RAM 0x5c > +#define SSD135X_SET_ROW_RANGE 0x75 … How do you think about to use an enumeration for such data? https://en.wikipedia.org/wiki/Enumerated_type#C_and_syntactically_similar_languages Regards, Markus