Re: [staging] staging: sm750fb: fix remaining CamelCase issues
kernel test robot <[email protected]>
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,dev.linux.lists.llvm,dev.linux.lists.oe-kbuild-all,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Arnav, kernel test robot noticed the following build errors: [auto build test ERROR on staging/staging-linus] [also build test ERROR on v7.1] [cannot apply to staging/staging-testing staging/staging-next linus/master next-20260623] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arnav-Kapoor/staging-sm750fb-fix-remaining-CamelCase-issues/20260622-235207 base: staging/staging-linus patch link: https://lore.kernel.org/r/20260621045340.65872-1-kapoorarnav43%40gmail.com patch subject: [staging] staging: sm750fb: fix remaining CamelCase issues config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20260624/[email protected]/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260624/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): >> drivers/staging/sm750fb/sm750.c:862:23: error: no member named 'power_mode' in 'struct init_status'; did you mean 'powerMode'? 862 | sm750_dev->init_parm.power_mode = 0; | ^~~~~~~~~~ | powerMode drivers/staging/sm750fb/sm750.h:42:9: note: 'powerMode' declared here 42 | ushort powerMode; | ^ >> drivers/staging/sm750fb/sm750.c:863:23: error: no member named 'set_all_eng_off' in 'struct init_status' 863 | sm750_dev->init_parm.set_all_eng_off = 0; | ~~~~~~~~~~~~~~~~~~~~ ^ >> drivers/staging/sm750fb/sm750.c:864:23: error: no member named 'reset_memory' in 'struct init_status'; did you mean 'resetMemory'? 864 | sm750_dev->init_parm.reset_memory = 1; | ^~~~~~~~~~~~ | resetMemory drivers/staging/sm750fb/sm750.h:48:9: note: 'resetMemory' declared here 48 | ushort resetMemory; | ^ >> drivers/staging/sm750fb/sm750.c:883:25: error: use of undeclared identifier 'SM750_DOUBLE_TFT' 883 | sm750_dev->pnltype = SM750_DOUBLE_TFT; | ^ >> drivers/staging/sm750fb/sm750.c:885:25: error: use of undeclared identifier 'SM750_DUAL_TFT' 885 | sm750_dev->pnltype = SM750_DUAL_TFT; | ^ 5 errors generated. vim +862 drivers/staging/sm750fb/sm750.c 850 851 /* chip specific g_option configuration routine */ 852 static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) 853 { 854 char *opt; 855 int swap; 856 857 swap = 0; 858 859 sm750_dev->init_parm.chip_clk = 0; 860 sm750_dev->init_parm.mem_clk = 0; 861 sm750_dev->init_parm.master_clk = 0; > 862 sm750_dev->init_parm.power_mode = 0; > 863 sm750_dev->init_parm.set_all_eng_off = 0; > 864 sm750_dev->init_parm.reset_memory = 1; 865 866 /* defaultly turn g_hwcursor on for both view */ 867 g_hwcursor = 3; 868 869 if (!src || !*src) { 870 dev_warn(&sm750_dev->pdev->dev, "no specific g_option.\n"); 871 goto NO_PARAM; 872 } 873 874 while ((opt = strsep(&src, ":")) != NULL && *opt != 0) { 875 dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt); 876 dev_info(&sm750_dev->pdev->dev, "src=%s\n", src); 877 878 if (!strncmp(opt, "swap", strlen("swap"))) { 879 swap = 1; 880 } else if (!strncmp(opt, "nocrt", strlen("nocrt"))) { 881 sm750_dev->nocrt = 1; 882 } else if (!strncmp(opt, "36bit", strlen("36bit"))) { > 883 sm750_dev->pnltype = SM750_DOUBLE_TFT; 884 } else if (!strncmp(opt, "18bit", strlen("18bit"))) { > 885 sm750_dev->pnltype = SM750_DUAL_TFT; 886 } else if (!strncmp(opt, "24bit", strlen("24bit"))) { 887 sm750_dev->pnltype = sm750_24TFT; 888 } else if (!strncmp(opt, "nohwc0", strlen("nohwc0"))) { 889 g_hwcursor &= ~0x1; 890 } else if (!strncmp(opt, "nohwc1", strlen("nohwc1"))) { 891 g_hwcursor &= ~0x2; 892 } else if (!strncmp(opt, "nohwc", strlen("nohwc"))) { 893 g_hwcursor = 0; 894 } else { 895 if (!g_fbmode[0]) { 896 g_fbmode[0] = opt; 897 dev_info(&sm750_dev->pdev->dev, 898 "find fbmode0 : %s\n", g_fbmode[0]); 899 } else if (!g_fbmode[1]) { 900 g_fbmode[1] = opt; 901 dev_info(&sm750_dev->pdev->dev, 902 "find fbmode1 : %s\n", g_fbmode[1]); 903 } else { 904 dev_warn(&sm750_dev->pdev->dev, "How many view you wann set?\n"); 905 } 906 } 907 } 908 909 NO_PARAM: 910 if (sm750_dev->revid != SM750LE_REVISION_ID) { 911 if (sm750_dev->fb_count > 1) { 912 if (swap) 913 sm750_dev->dataflow = sm750_dual_swap; 914 else 915 sm750_dev->dataflow = sm750_dual_normal; 916 } else { 917 if (swap) 918 sm750_dev->dataflow = sm750_simul_sec; 919 else 920 sm750_dev->dataflow = sm750_simul_pri; 921 } 922 } else { 923 /* SM750LE only have one crt channel */ 924 sm750_dev->dataflow = sm750_simul_sec; 925 /* sm750le do not have complex attributes */ 926 sm750_dev->nocrt = 0; 927 } 928 } 929 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki