Re: [PATCH] staging: fbtft: replace empty modifier argument with no-op macro
Sai Madhu <[email protected]>
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAB0uMAeMOV4Xhq2cNVjxne89yqF8vdubM8-OpPYGK4f4yBLMNw@mail.gmail.com> |
Hi Dan, Thank you for the feedback. I understand and will drop this patch. I have also noticed two pre-existing bugs in the same file (unaligned access and buffer size calculation when startbyte is used) and have sent a separate patch to fix those. Regards, suryasaimadhu On Thu, 25 Jun 2026 at 15:58, Dan Carpenter <[email protected]> wrote: > > On Thu, Jun 25, 2026 at 05:27:21PM +0800, suryasaimadhu wrote: > > Define fbtft_write_reg_no_modifier() as an identity function and > > use it in place of empty modifier arguments in define_fbtft_write_reg() > > calls to fix checkpatch errors. > > > > Signed-off-by: suryasaimadhu <[email protected]> > > --- > > I don't hate this patch, but I think we've decided to leave this > as-is. > > regards, > dan carpenter >