[PATCH v6] staging: sm750fb: Remove unused variable 'setAllEngOff'
André Moreira <[email protected]> Wed, 8 Jul 2026 03:03:07 -0300
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The variable 'setAllEngOff' within the 'init_status' struct is only set to zero during setup but its value is never read anywhere else in the driver. Remove it entirely to clean up the code. Signed-off-by: André Moreira <[email protected]> --- v6: - Change patch approach from renaming CamelCase to entirely removing the unused 'setAllEngOff' variable, based on Greg KH's feedback. v5: - Fix broken diff from v4 that was accidentally recreating the entire struct. - Update the variable usage inside drivers/staging/sm750fb/sm750.c to prevent compilation errors. v4: - Drop register renames 'pvReg' to 'regs' as they were merged via another upstream patch. - Keep only the 'init_status' CamelCase cleanup. v3: - Added changelog history to satisfy the bot. v2: - Renamed 'pv_reg' to 'regs' to completely remove Hungarian notation, based on Greg KH's feedback. drivers/staging/sm750fb/sm750.c | 1 - drivers/staging/sm750fb/sm750.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 89c811e0806c4..f676f1716cf89 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -848,7 +848,6 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) sm750_dev->init_parm.mem_clk = 0; sm750_dev->init_parm.master_clk = 0; sm750_dev->init_parm.power_mode = 0; - sm750_dev->init_parm.setAllEngOff = 0; sm750_dev->init_parm.reset_memory = 1; /* defaultly turn g_hwcursor on for both view */ diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index d2c522e67f26a..e7b8626cb876e 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -44,7 +44,6 @@ struct init_status { ushort chip_clk; ushort mem_clk; ushort master_clk; - ushort setAllEngOff; ushort reset_memory; }; -- 2.43.0