Re: [PATCH v6] staging: sm750fb: Remove unused variable 'setAllEngOff'

Andre Moreira <[email protected]> Wed, 8 Jul 2026 10:09:09 -0300

Newsgroups	org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel
Message-ID	<CACO0qFJhE-p1NfEo-oVfVrrmxr=QUmOy0L3OihE6yTd=CeQQiw@mail.gmail.com>

Hi Greg,

Please disregard this patch. Upon rebasing against staging-testing, I
noticed that 'setAllEngOff' was recently renamed to 'set_all_eng_off'
and its value is now actually being read/used inside
drivers/staging/sm750fb/ddk750_chip.c.

Thank you for your time!

Regards,
André

Em qua., 8 de jul. de 2026 às 09:01, Greg Kroah-Hartman
<[email protected]> escreveu:
>
> On Wed, Jul 08, 2026 at 03:03:07AM -0300, André Moreira wrote:
> > The variable 'setAllEngOff' within the 'init_status' struct is only
> > set to zero during setup but its value is never read anywhere else
> > in the driver. Remove it entirely to clean up the code.
> >
> > Signed-off-by: André Moreira <[email protected]>
> > ---
> > v6:
> >   - Change patch approach from renaming CamelCase to entirely removing
> >     the unused 'setAllEngOff' variable, based on Greg KH's feedback.
>
> This doesn't apply to my tree at all.  Can you rebase against the
> staging-testing branch and resend?
>
> thanks,
>
> greg k-h