Re: [PATCH 01/16] dt-bindings: twl-regulator: Add bindings for exposing ti,twl4030-regen

Krzysztof Kozlowski <[email protected]> Mon, 13 Jul 2026 11:19:52 +0200

Newsgroups	org.kernel.vger.linux-fbdev,dev.linux.lists.mfd,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-omap,org.kernel.vger.linux-sound
Message-ID	<[email protected]>

On 13/07/2026 10:26, H. Nikolaus Schaller wrote:
> Hi Krzysztof,
> 
> Thank you for the feedback.
> 
>> Am 13.07.2026 um 09:39 schrieb Krzysztof Kozlowski <[email protected]>:
>>
>> On Sat, Jul 11, 2026 at 08:01:48AM +0200, H. Nikolaus Schaller wrote:
>>> From: Grond <[email protected]>
>>>
>>> FIXME: not reflected in the bindings
>>>
>>> +Reguired properties:
>>> +For twl3040 REGEN signal:
>>> + - regulator-min-microvolt:
>>> +  - Same meaning as in bindings/regulator/regulator.yaml, but must match
>>> +    regulator-max-microvolt.
>>> + - regulator-max-microvolt:
>>> +  - Same meaning as in bindings/regulator/regulator.yaml, but must match
>>> +    regulator-min-microvolt.
>>> + - startup-delay-us:
>>> +  - Same meaning as in bindings/regulator/fixed-regulator.yaml.
>>
>> I don't know what that means.
>>
>>>
>>> Signed-off-by: Grond <[email protected]>
>>
>> As explicitly written in submitting patches: we do not take anonymous
>> contributions.
> 
> Thanks for pointing this out. In more than 10 years of contributing, I actually have never run into this specific issue before.
> 
> To give some context: this is a contribution we received on our mailing list about 5 years ago. We do not know the author personally, but the code looks good and has been thoroughly tested by us. I kept their Signed-off-by because I didn't want to falsely claim authorship.

Take the authorship. You are allowed to do that by both DCO and common
sense (you are not doing something immoral, unless author shows
interest/hints to fix it by themself).

Commit msg also needs fixing/rewriting.

Beside, one more nit since there will be a new version:

A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

Also, please wrap your replies to mailing list wrapping style.

Best regards,
Krzysztof