Re: [PATCH 2/2] staging: sm750fb: unindent defines left by conditional removal

On Sat, Jul 18, 2026 at 05:57:58AM +0000, Nils Lehnen wrote:
> The preceding removal of the VALIDATION_CHIP conditionals left the
> surviving define blocks and one comment indented by four spaces, and
> two double blank lines where conditional lines went away. Move the
> now-unconditional defines to column zero while keeping the aligned
> value column untouched, and collapse the blank lines.
> 
> No functional change: whitespace and preprocessor layout only; the
> disassembly of all ten sm750fb object files stays bit-identical.
> 
> All English text in this patch (commit message and code comments) was
> translated from a German draft with the assistance of Claude Fable 5.
> 
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Nils Lehnen <[email protected]>
> ---
>  drivers/staging/sm750fb/ddk750_reg.h | 50 +++++++++++++---------------
>  1 file changed, 24 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers/staging/sm750fb/ddk750_reg.h
> index 4bcede37584a..2888ffe32fa2 100644
> --- a/drivers/staging/sm750fb/ddk750_reg.h
> +++ b/drivers/staging/sm750fb/ddk750_reg.h
> @@ -294,15 +294,15 @@
>  
>  #define CURRENT_GATE                                  0x000040
>  #define CURRENT_GATE_MCLK_MASK                        (0x3 << 14)
> -    #define CURRENT_GATE_MCLK_DIV_3                   (0x0 << 14)
> -    #define CURRENT_GATE_MCLK_DIV_4                   (0x1 << 14)
> -    #define CURRENT_GATE_MCLK_DIV_6                   (0x2 << 14)
> -    #define CURRENT_GATE_MCLK_DIV_8                   (0x3 << 14)
> +#define CURRENT_GATE_MCLK_DIV_3                       (0x0 << 14)
> +#define CURRENT_GATE_MCLK_DIV_4                       (0x1 << 14)
> +#define CURRENT_GATE_MCLK_DIV_6                       (0x2 << 14)
> +#define CURRENT_GATE_MCLK_DIV_8                       (0x3 << 14)
>  #define CURRENT_GATE_M2XCLK_MASK                      (0x3 << 12)

No, this is not correct, the indentation gives you context of what is
happening.

thanks,

greg k-h