[PATCH] fbdev: replace dead select with dependency
Julian Braha <[email protected]> Wed, 22 Jul 2026 23:00:23 +0100
| Newsgroups | org.kernel.vger.linux-fbdev,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
'select' does not work on config options in a 'choice', so currently it is possible to enable FB_MB862XX_LIME without FB_LITTLE_ENDIAN. We cannot replace the 'select FB_LITTLE_ENDIAN' without also changing FB_FOREIGN_ENDIAN from 'select' to 'depends on', otherwise we will get a recursive dependency. Note that, if we remove the select / dependency, the kernel will compile with FB_MB862XX_LIME=y and FB_LITTLE_ENDIAN=n so if it would be better to remove the select, please advise as I do not have the hardware to runtime test this. This dead select was found by kconfirm, a static analysis tool for Kconfig. Signed-off-by: Julian Braha <[email protected]> --- drivers/video/fbdev/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 085d3a202148..1ed4506c0cb2 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1717,8 +1717,8 @@ config FB_MB862XX_PCI_GDC config FB_MB862XX_LIME bool "Lime GDC" depends on OF && PPC - select FB_FOREIGN_ENDIAN - select FB_LITTLE_ENDIAN + depends on FB_FOREIGN_ENDIAN + depends on FB_LITTLE_ENDIAN help Framebuffer support for Fujitsu Lime GDC on host CPU bus. -- 2.54.0