Re: [PATCH 2/2] staging: sm750fb: Remove unused function sm750_enable_dma
Dan Carpenter <[email protected]> Sat, 25 Jul 2026 11:59:45 +0300
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Jul 25, 2026 at 02:16:49PM +0530, Mohit Mishra wrote:
> diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750fb/ddk750_power.c
> index d617f554f58d..e4bea8da1827 100644
> --- a/drivers/staging/sm750fb/ddk750_power.c
> +++ b/drivers/staging/sm750fb/ddk750_power.c
> @@ -90,19 +90,6 @@ void sm750_enable_2d_engine(unsigned int enable)
> sm750_set_current_gate(gate);
> }
>
> -void sm750_enable_dma(unsigned int enable)
> -{
> - u32 gate;
> -
> - /* Enable DMA Gate */
> - gate = peek32(CURRENT_GATE);
> - if (enable)
> - gate |= CURRENT_GATE_DMA;
> - else
> - gate &= ~CURRENT_GATE_DMA;
> -
> - sm750_set_current_gate(gate);
> -}
>
You need to delete the blank line afterwards as well otherwise there
are two blank lines in a row and checkpatch.pl -f will complain:
CHECK: Please don't use multiple blank lines
#93: FILE: drivers/staging/sm750fb/ddk750_power.c:93:
+
+
regards,
dan carpenter