Re: [PATCH v2 1/2] staging: sm750fb: Remove dead VALIDATION_CHIP preprocessor blocks
Dan Carpenter <[email protected]> Sat, 25 Jul 2026 12:22:12 +0300
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Jul 25, 2026 at 02:37:48PM +0530, Mohit Mishra wrote: > The macro VALIDATION_CHIP is not defined anywhere in the kernel source > tree. Hence, '#ifdef VALIDATION_CHIP' blocks are dead code, and '#ifndef > VALIDATION_CHIP' blocks are always active. > > Remove the dead conditional blocks, keeping only the active paths, and > clean up the unused macro definitions. > > This addresses the first task in the drivers/staging/sm750fb/TODO list: > "- refine the code and remove unused code". > > Signed-off-by: Mohit Mishra <[email protected]> > --- Reviewed-by: Dan Carpenter <[email protected]> regards, dan carpenter