Re: [PATCH 1/2] fbdev: ssd1307fb: add support for Sino Wealth SH1107 controller

Jakub Turek <[email protected]> writes:

Hello Jakub,

> The SH1107 display controller is very similar to SSD1307 but the main
> difference is that SH1107 has different memory layout and uses page mode
> adressation only.
>
> The SH1107 relies primarily on vertical page addressing mode where the
> internal 128x128 GDDRAM is split into 16 vertical pages, rather than
> the horizontal/tile addressing modes natively utilized by the
> SSD1306/SSD1307.
>
> Signed-off-by: Jakub Turek  <[email protected]>
> ---


The fbdev driver is obsolete and likely to be removed soon. Instead please
use the KMS driver (drivers/gpu/drm/solomon/ssd130x*). This already has
support for the sh1106, so adding ssh1307 support should be trivial

(basically just adding an entry to the device ID tables I believe).

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat