Re: [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally

"Maciej W. Rozycki" <[email protected]>
Newsgroups org.kernel.vger.linux-fbdev,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Fri, 14 Aug 2026, Randy Dunlap wrote:

> This driver cannot be built as a loadable module so testing for
> "#ifdef MODULE" is not appropriate here.
> Also, MODULE_LICENSE() is always available.

 It might best be reordered to the end of file, cf. pmagb-b-fb.c, though 
I'm not sure if we want to be pedantic enough to do it with a separate 
change.  Anyway:

Acked-by: Maciej W. Rozycki <[email protected]>

 NB making the driver modular ought to be trivial once this has become a 
platform device; I have converted all the TURBOchannel drivers already.  
I have hesitated poking at this one without a live specimen though.

  Maciej
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.