[PATCH v3] fbdev: platinumfb: add error checking for ioremap calls
Yue Bing Kun <[email protected]>
| Newsgroups | org.kernel.vger.linux-fbdev,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
From: BingKun Yue <[email protected]> The ioremap() and ioremap_wt() calls in platinumfb_probe() were not checked for failure. If any of these mappings fail, the driver would dereference NULL pointers, leading to a kernel panic. Add proper error checking and use goto-based cleanup to avoid code duplication across the error paths. Reported-by: Nathan Chancellor <[email protected]> Link: https://lore.kernel.org/linux-fbdev/20260819235918.GA2021182@ax162/ Signed-off-by: BingKun Yue <[email protected]> --- drivers/video/fbdev/platinumfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/platinumfb.c b/drivers/video/fbdev/platinumfb.c index fdffadcc3e73..f74c937c839f 100644 --- a/drivers/video/fbdev/platinumfb.c +++ b/drivers/video/fbdev/platinumfb.c @@ -320,7 +320,7 @@ static void platinum_init_info(struct fb_info *info, fb_alloc_cmap(&info->cmap, 256, 0); /* Fill fix common fields */ - strscpy(info->fix.id, "platinum", sizeof(info->fix.id)); + strcpy(info->fix.id, "platinum"); info->fix.mmio_start = pinfo->platinum_regs_phys; info->fix.mmio_len = 0x1000; info->fix.type = FB_TYPE_PACKED_PIXELS; -- 2.43.0