Re: [PATCH 1/2] ptp: split clock drivers into two subdirectories

Wen Gu <[email protected]> Tue, 24 Mar 2026 10:59:47 +0800
Newsgroups org.kernel.vger.linux-fpga,dev.linux.lists.imx,org.kernel.vger.linux-kernel,org.kernel.vger.linux-s390,org.kernel.vger.netdev
Message-ID <[email protected]>

On 2026/3/24 10:16, Jakub Kicinski wrote:
> On Wed, 18 Mar 2026 15:33:29 +0800 Wen Gu wrote:
>>   drivers/ptp/emulated/Kconfig                 |  61 +++++
>>   drivers/ptp/emulated/Makefile                |  11 +
>>   drivers/ptp/{ => emulated}/ptp_kvm_arm.c     |   0
>>   drivers/ptp/{ => emulated}/ptp_kvm_common.c  |   0
>>   drivers/ptp/{ => emulated}/ptp_kvm_x86.c     |   0
>>   drivers/ptp/{ => emulated}/ptp_s390.c        |   0
>>   drivers/ptp/{ => emulated}/ptp_vmclock.c     |   0
>>   drivers/ptp/{ => emulated}/ptp_vmw.c         |   0
>>   drivers/ptp/ieee1588/Kconfig                 | 179 +++++++++++++
>>   drivers/ptp/ieee1588/Makefile                |  16 ++
>>   drivers/ptp/{ => ieee1588}/ptp_clockmatrix.c |   0
>>   drivers/ptp/{ => ieee1588}/ptp_clockmatrix.h |   0
>>   drivers/ptp/{ => ieee1588}/ptp_dfl_tod.c     |   0
>>   drivers/ptp/{ => ieee1588}/ptp_dte.c         |   0
>>   drivers/ptp/{ => ieee1588}/ptp_fc3.c         |   0
>>   drivers/ptp/{ => ieee1588}/ptp_fc3.h         |   0
>>   drivers/ptp/{ => ieee1588}/ptp_idt82p33.c    |   0
>>   drivers/ptp/{ => ieee1588}/ptp_idt82p33.h    |   0
>>   drivers/ptp/{ => ieee1588}/ptp_ines.c        |   0
>>   drivers/ptp/{ => ieee1588}/ptp_mock.c        |   0
>>   drivers/ptp/{ => ieee1588}/ptp_netc.c        |   0
>>   drivers/ptp/{ => ieee1588}/ptp_ocp.c         |   0
>>   drivers/ptp/{ => ieee1588}/ptp_pch.c         |   0
>>   drivers/ptp/{ => ieee1588}/ptp_qoriq.c       |   0
>>   26 files changed, 296 insertions(+), 253 deletions(-)
> 
> emulated sounds good but the ieee1588 doesn't sit well with me.
> IEEE1588 doesn't describe tickers and external signals.
> Let's leave them in the main directory? Or call it hw even if
> it's not 100% accurate? In MAINTAINERS you can exclude subdir
> with X:

Thanks for the suggestion. Leaving the network-oriented drivers
in the main directory and using X: in MAINTAINERS to exclude the
emulated ones makes sense to me. The layout will be adjusted in
the next version.