Re: [PATCH] fpga: zynq-fpga: Remove redundant dev_err()
Michal Simek <[email protected]> Mon, 13 Jul 2026 15:48:57 +0200
| Newsgroups | org.kernel.vger.linux-fpga,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/13/26 15:22, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <[email protected]>
> ---
> drivers/fpga/zynq-fpga.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 9d1d599ef718..2f8ba32e4002 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -598,7 +598,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> err = devm_request_irq(dev, priv->irq, zynq_fpga_isr, 0, dev_name(dev),
> priv);
> if (err) {
> - dev_err(dev, "unable to request IRQ\n");
> clk_disable_unprepare(priv->clk);
> return err;
> }
Reviewed-by: Michal Simek <[email protected]>
Thanks,
Michal