Re: [PATCH v2 037/110] minix: use PRIino format for i_ino
Jan Kara <[email protected]>
| Newsgroups | org.kernel.vger.linux-fscrypt,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.autofs,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <kywopfbqsllo7hy75okmrpljpjppknqbqk26hl4lp7vzspif6w@vs2n3nni4vda> |
On Mon 02-03-26 15:24:21, Jeff Layton wrote: > Convert minix i_ino format strings to use the PRIino format > macro in preparation for the widening of i_ino via kino_t. > > Signed-off-by: Jeff Layton <[email protected]> Looks good. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/minix/inode.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/minix/inode.c b/fs/minix/inode.c > index 99541c6a5bbf13f3be27474a316b31d8db9fbce0..d92059227d273564c86f100dea3366be4509090b 100644 > --- a/fs/minix/inode.c > +++ b/fs/minix/inode.c > @@ -36,7 +36,7 @@ void __minix_error_inode(struct inode *inode, const char *function, > vaf.fmt = fmt; > vaf.va = &args; > printk(KERN_CRIT "minix-fs error (device %s): %s:%d: " > - "inode #%lu: comm %s: %pV\n", > + "inode #%" PRIino "u: comm %s: %pV\n", > inode->i_sb->s_id, function, line, inode->i_ino, > current->comm, &vaf); > va_end(args); > @@ -520,7 +520,7 @@ void minix_set_inode(struct inode *inode, dev_t rdev) > S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) { > init_special_inode(inode, inode->i_mode, rdev); > } else { > - printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode %lu.\n", > + printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode %" PRIino "u.\n", > inode->i_mode, inode->i_ino); > make_bad_inode(inode); > } > @@ -542,7 +542,7 @@ static struct inode *V1_minix_iget(struct inode *inode) > return ERR_PTR(-EIO); > } > if (raw_inode->i_nlinks == 0) { > - printk("MINIX-fs: deleted inode referenced: %lu\n", > + printk("MINIX-fs: deleted inode referenced: %" PRIino "u\n", > inode->i_ino); > brelse(bh); > iget_failed(inode); > @@ -580,7 +580,7 @@ static struct inode *V2_minix_iget(struct inode *inode) > return ERR_PTR(-EIO); > } > if (raw_inode->i_nlinks == 0) { > - printk("MINIX-fs: deleted inode referenced: %lu\n", > + printk("MINIX-fs: deleted inode referenced: %" PRIino "u\n", > inode->i_ino); > brelse(bh); > iget_failed(inode); > @@ -692,7 +692,7 @@ static int minix_write_inode(struct inode *inode, struct writeback_control *wbc) > if (wbc->sync_mode == WB_SYNC_ALL && buffer_dirty(bh)) { > sync_dirty_buffer(bh); > if (buffer_req(bh) && !buffer_uptodate(bh)) { > - printk("IO error syncing minix inode [%s:%08lx]\n", > + printk("IO error syncing minix inode [%s:%08" PRIino "x]\n", > inode->i_sb->s_id, inode->i_ino); > err = -EIO; > } > > -- > 2.53.0 > -- Jan Kara <[email protected]> SUSE Labs, CR