Re: [PATCH v2 059/110] vfs: use PRIino format for i_ino
Jan Kara <[email protected]>
| Newsgroups | org.kernel.vger.linux-fscrypt,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.autofs,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <mtsi6ueq2rz2kjwsc7hesxpck7amge2zjqdeptzf5jom26sdo2@z4t6nryzbley> |
On Mon 02-03-26 15:24:43, Jeff Layton wrote: > Convert i_ino format strings in pipe, dcache, fserror, and eventpoll to > use the PRIino format macro and update the 0UL literal in dcache to > (kino_t)0. > > Signed-off-by: Jeff Layton <[email protected]> Looks good. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/dcache.c | 4 ++-- > fs/eventpoll.c | 2 +- > fs/fserror.c | 2 +- > fs/pipe.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/dcache.c b/fs/dcache.c > index 24f4f3acaa8cffd6f98124eec38c1a92d6c9fd8e..13fb3e89cba7442c9bed74c41ca18be5e43e28c9 100644 > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -1637,11 +1637,11 @@ static enum d_walk_ret umount_check(void *_data, struct dentry *dentry) > if (dentry == _data && dentry->d_lockref.count == 1) > return D_WALK_CONTINUE; > > - WARN(1, "BUG: Dentry %p{i=%lx,n=%pd} " > + WARN(1, "BUG: Dentry %p{i=%" PRIino "x,n=%pd} " > " still in use (%d) [unmount of %s %s]\n", > dentry, > dentry->d_inode ? > - dentry->d_inode->i_ino : 0UL, > + dentry->d_inode->i_ino : (kino_t)0, > dentry, > dentry->d_lockref.count, > dentry->d_sb->s_type->name, > diff --git a/fs/eventpoll.c b/fs/eventpoll.c > index 5714e900567c499739bb205f43bb6bf73f7ebe54..90fd92425492221d13bd0cf067d47579bb407a01 100644 > --- a/fs/eventpoll.c > +++ b/fs/eventpoll.c > @@ -1080,7 +1080,7 @@ static void ep_show_fdinfo(struct seq_file *m, struct file *f) > struct inode *inode = file_inode(epi->ffd.file); > > seq_printf(m, "tfd: %8d events: %8x data: %16llx " > - " pos:%lli ino:%lx sdev:%x\n", > + " pos:%lli ino:%" PRIino "x sdev:%x\n", > epi->ffd.fd, epi->event.events, > (long long)epi->event.data, > (long long)epi->ffd.file->f_pos, > diff --git a/fs/fserror.c b/fs/fserror.c > index 06ca86adab9b769dfb72ec58b9e51627abee5152..b685b329b5956a639c41b25c42cfff16e6e5ab6e 100644 > --- a/fs/fserror.c > +++ b/fs/fserror.c > @@ -176,7 +176,7 @@ void fserror_report(struct super_block *sb, struct inode *inode, > lost: > if (inode) > pr_err_ratelimited( > - "%s: lost file I/O error report for ino %lu type %u pos 0x%llx len 0x%llx error %d", > + "%s: lost file I/O error report for ino %" PRIino "u type %u pos 0x%llx len 0x%llx error %d", > sb->s_id, inode->i_ino, type, pos, len, error); > else > pr_err_ratelimited( > diff --git a/fs/pipe.c b/fs/pipe.c > index b44a756c0b4165edc2801b2290bf35480245d7a6..311928e8713989747605fd79f653e36d27ce8c0e 100644 > --- a/fs/pipe.c > +++ b/fs/pipe.c > @@ -873,7 +873,7 @@ static struct vfsmount *pipe_mnt __ro_after_init; > */ > static char *pipefs_dname(struct dentry *dentry, char *buffer, int buflen) > { > - return dynamic_dname(buffer, buflen, "pipe:[%lu]", > + return dynamic_dname(buffer, buflen, "pipe:[%" PRIino "u]", > d_inode(dentry)->i_ino); > } > > > -- > 2.53.0 > -- Jan Kara <[email protected]> SUSE Labs, CR