Re: [PATCH v2 067/110] proc: replace PRIino with %llu/%llx format strings
Jan Kara <[email protected]>
| Newsgroups | org.kernel.vger.linux-fscrypt,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.autofs,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <6myy5axw5zn3e3gtmxrfw2iynowkont7dc7mm74j24cvecrewb@7qitmwzmad2k> |
On Mon 02-03-26 15:24:51, Jeff Layton wrote: > Now that i_ino is u64 and the PRIino format macro has been removed, > replace all uses in proc with the concrete format strings. > > Signed-off-by: Jeff Layton <[email protected]> Looks good. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/proc/fd.c | 2 +- > fs/proc/task_mmu.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/proc/fd.c b/fs/proc/fd.c > index 936d0258d688be5fdc384ee5c4dfbb8fa0d19dff..aae1a83e884686471758703634f0d3479e77c9a7 100644 > --- a/fs/proc/fd.c > +++ b/fs/proc/fd.c > @@ -54,7 +54,7 @@ static int seq_show(struct seq_file *m, void *v) > if (ret) > return ret; > > - seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\nino:\t%" PRIino "u\n", > + seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\nino:\t%llu\n", > (long long)file->f_pos, f_flags, > real_mount(file->f_path.mnt)->mnt_id, > file_inode(file)->i_ino); > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 702b0f0433f91077cd0d0af4a07e9d67d9fa9a45..751b9ba160fbf15499555875871d727644b0df44 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -442,7 +442,7 @@ static void get_vma_name(struct vm_area_struct *vma, > static void show_vma_header_prefix(struct seq_file *m, > unsigned long start, unsigned long end, > vm_flags_t flags, unsigned long long pgoff, > - dev_t dev, kino_t ino) > + dev_t dev, u64 ino) > { > seq_setwidth(m, 25 + sizeof(void *) * 6 - 1); > seq_put_hex_ll(m, NULL, start, 8); > @@ -465,7 +465,7 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma) > const struct path *path; > const char *name_fmt, *name; > vm_flags_t flags = vma->vm_flags; > - kino_t ino = 0; > + u64 ino = 0; > unsigned long long pgoff = 0; > unsigned long start, end; > dev_t dev = 0; > > -- > 2.53.0 > -- Jan Kara <[email protected]> SUSE Labs, CR