Re: [PATCH] cachefiles,netfs: sunset ondemand mode

> commit 3d2befc6d8d7e85b20d92f4baab590a997635d81
> Author: Gao Xiang <[email protected]>
>
> cachefiles,netfs: sunset ondemand mode
>
> It was an effort to enhance fscache as a kernel cache for lazy
> pulling (at least according to previous Incremental FS discussion [1])
> and EROFS over fscache was the in-tree user of this mode.
>
> fscache has since evolved to be netfslib-oriented, serving network
> filesystem inodes via the netfs library, but EROFS never acts as a
> network filesystem and we need to cache golden filesystem images rather
> than individual EROFS inodes.
>
> Since EROFS over fscache is now removed, clean up netfs/fscache/
> cachefiles upstream too.
>
> [1] https://lore.kernel.org/r/CAOQ4uxi4dzxArY24YO=+kBCK2gGoq3Ptb8WkzCqSogPgU_R3dQ@mail.gmail.com
>
> [dh] Fixed up comments on:
> https://sashiko.dev/#/patchset/20260716103030.3065561-1-dhowells%40redhat.com
> https://sashiko.dev/#/patchset/20260722130218.78958-1-dhowells%40redhat.com

This isn't a bug, but would it be worth turning those two review tool
URLs into Link: tags with lore message-ids instead, or dropping the note
before it lands?  The rest of the message follows the usual format, so
this block reads as leftover process metadata.

[ ... ]

> diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h
> index b62cd3e9a18e..c93324e0f98c 100644
> --- a/fs/cachefiles/internal.h
> +++ b/fs/cachefiles/internal.h

[ ... ]

> @@ -298,90 +250,6 @@ extern struct file *cachefiles_create_tmpfile(struct cachefiles_object *object);
>  extern bool cachefiles_commit_tmpfile(struct cachefiles_cache *cache,
>  				      struct cachefiles_object *object);
>
> -/*
> - * ondemand.c
> - */
> -#ifdef CONFIG_CACHEFILES_ONDEMAND
> -extern ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
> -					char __user *_buffer, size_t buflen);
> -
> -extern int cachefiles_ondemand_copen(struct cachefiles_cache *cache,
> -				     char *args);

[ ... ]

> -extern int cachefiles_ondemand_read(struct cachefiles_object *object,
> -				    loff_t pos, size_t len);

[ ... ondemand section removed ... ]

This isn't a bug, but now that ondemand.c is gone, io.c is the only user
of __cachefiles_prepare_write() and __cachefiles_write().  Would it be
worth making them static and dropping their declarations from internal.h?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31607781274